Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: removing first person from 2 sentences #37768

Closed
wants to merge 1 commit into from
Closed

docs: removing first person from 2 sentences #37768

wants to merge 1 commit into from

Conversation

maksymiliansielicki
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [x ] Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

n/a

What is the new behavior?

n/a

Does this PR introduce a breaking change?

  • Yes
  • [x ] No

Other information

@pullapprove pullapprove bot requested a review from AndrewKushnir June 26, 2020 08:54
@maksymiliansielicki
Copy link
Contributor Author

@kapunahelewong Hi! I've made the changes you suggested in #36188 :)

@ngbot ngbot bot modified the milestone: needsTriage Jun 26, 2020
kapunahelewong
kapunahelewong reviewed Jun 26, 2020
View reviewed changes
Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you, @Maxmeister! Just one tiny suggestion about the changes. Then to get it to pass, we just need to meet the 100 character minimum for the body of the commit message. If you try this, it should pass:

docs: remove first person from 2 sentences 

This commit removes two instances of the first person in the 
Dependency injection providers documentation.

Make sure you have a blank line before and after the body of the commit message just like this.^^

If you need any help, just let me know. You may also be interested in the notes I keep on how to squash (which you'll need to do if you have a second commit) and how to amend a commit.

aio/content/guide/dependency-injection-providers.md Outdated Show resolved Hide resolved
@kapunahelewong kapunahelewong added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release type: bug/fix labels Jun 26, 2020
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 26, 2020
@maksymiliansielicki
docs: remove first person from 2 sentences
40fbfe6 
This commit removes two instances of the first person in the
Dependency injection providers documentation.
@maksymiliansielicki
Copy link
Contributor Author

maksymiliansielicki commented Jun 27, 2020 •
edited

@kapunahelewong I've made the changes you suggested. Thank you so much for help! I use Angular in my daily work and contributing to it means a lot to me

@kapunahelewong
Copy link
Contributor

How nice to hear, @Maxmeister. 😊

And it is so nice that you've taken the time to help make Angular better. Thank you! 🌸

LGTM!

Reviewed-for: global-docs-approvers

@kapunahelewong kapunahelewong added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jun 29, 2020
AndrewKushnir pushed a commit that referenced this pull request Jun 29, 2020
@maksymiliansielicki @AndrewKushnir
docs: remove first person from 2 sentences (#37768)
a2520bd 
This commit removes two instances of the first person in the
Dependency injection providers documentation.

PR Close #37768
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@maksymiliansielicki @profanis
docs: remove first person from 2 sentences (angular#37768)
44d461f 
This commit removes two instances of the first person in the
Dependency injection providers documentation.

PR Close angular#37768
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kapunahelewong kapunahelewong kapunahelewong approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maksymiliansielicki @kapunahelewong @AndrewKushnir @googlebot